Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the XDG Base Directory Specification. #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denisfa
Copy link

@denisfa denisfa commented Apr 19, 2019

Hey @joeyespo.

This is a fix for #286. We adopt the solution as given by the table in this comment. The order of precedence is:

  1. ${GRIPHOME}/settings.py (if GRIPHOME is set)
  2. ~/.grip/settings.py (if ~/.grip exists)
  3. ${XDG_CONFIG_HOME:-~/.config}/grip/settings.py (fallback)

Also, the cache files are in ${XDG_CACHE_HOME:-~/.cache}/grip. I believe these files are not important at all for the user, hence I decided to not have a migration path for them.

Feel free to comment whatever you want about this.

@alichtman
Copy link

Hey @joeyespo, any update on this PR?

@shinenelson
Copy link

almost another year later, here is another person showing interest and support for this pull request to be merged. I checked this pull request ref out and tried it. It worked as expected for me. Can we please merge this pull request? I do not see any issues that is blocking it.

@alichtman
Copy link

alichtman commented Jun 19, 2022

Hey @joeyespo, can you merge this?

@toh995
Copy link

toh995 commented Jun 20, 2022

I'd love to see this merged as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants