Skip to content

chore: update insta snapshots to newer format#429

Merged
jdx merged 1 commit intomainfrom
chore/update-insta-snapshots
Jan 19, 2026
Merged

chore: update insta snapshots to newer format#429
jdx merged 1 commit intomainfrom
chore/update-insta-snapshots

Conversation

@jdx
Copy link
Owner

@jdx jdx commented Jan 19, 2026

Summary

  • Removes legacy assertion_line metadata from insta snapshot files
  • Snapshots now use the current insta format

This was identified by warnings when running tests:

Snapshot test passes but the existing value is in a legacy format. Please run `cargo insta test --force-update-snapshots` to update to a newer format.

🤖 Generated with Claude Code


Note

Updates insta snapshot files for shell completion tests to the current format.

  • Removes legacy assertion_line metadata from *.snap for bash/fish/zsh completion snapshots
  • Regenerates snapshots without changing completion logic or source code

Written by Cursor Bugbot for commit b69716b. This will update automatically on new commits. Configure here.

Remove legacy assertion_line metadata from snapshot files.
This eliminates the warnings during test runs.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings January 19, 2026 02:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates insta snapshot files to the current format by removing deprecated assertion_line metadata fields. The changes address warnings that appeared during test execution about legacy snapshot formats.

Changes:

  • Removes assertion_line metadata from snapshot file headers
  • Updates three snapshot files to match current insta format specification

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/src/complete/snapshots/usage__complete__zsh__tests__complete_zsh-3.snap Removed deprecated assertion_line metadata
lib/src/complete/snapshots/usage__complete__fish__tests__complete_fish-3.snap Removed deprecated assertion_line metadata
lib/src/complete/snapshots/usage__complete__bash__tests__complete_bash-3.snap Removed deprecated assertion_line metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.08%. Comparing base (57db233) to head (b69716b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   47.64%   46.08%   -1.57%     
==========================================
  Files          45       45              
  Lines        6164     6241      +77     
  Branches     6164     6241      +77     
==========================================
- Hits         2937     2876      -61     
- Misses       1553     1630      +77     
- Partials     1674     1735      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jdx jdx merged commit 4a33383 into main Jan 19, 2026
10 of 11 checks passed
@jdx jdx deleted the chore/update-insta-snapshots branch January 19, 2026 02:56
jdx pushed a commit that referenced this pull request Jan 19, 2026
### 🚀 Features

- **(release)** add LLM-generated prose summary to release notes by
[@jdx](https://github.com/jdx) in
[#421](#421)
- add LLM-generated release notes for GitHub releases by
[@jdx](https://github.com/jdx) in
[#423](#423)
- add spec lint command by [@jdx](https://github.com/jdx) in
[#430](#430)

### 🐛 Bug Fixes

- replace unsafe path unwrap chains with proper error handling by
[@jdx](https://github.com/jdx) in
[#424](#424)
- pass positional args through to executed scripts by
[@jdx](https://github.com/jdx) in
[#425](#425)
- replace unimplemented!() with proper errors for unsupported shells by
[@jdx](https://github.com/jdx) in
[#432](#432)
- update claude CLI model and add bypassPermissions by
[@jdx](https://github.com/jdx) in
[#435](#435)

### 🚜 Refactor

- remove unused double-shebang support by [@jdx](https://github.com/jdx)
in [#426](#426)
- replace once_cell with std::sync::LazyLock by
[@jdx](https://github.com/jdx) in
[#428](#428)
- improve code quality with safety and lint fixes by
[@jdx](https://github.com/jdx) in
[#427](#427)

### ⚡ Performance

- use Arc for flag/arg keys in ParseOutput to reduce cloning by
[@jdx](https://github.com/jdx) in
[#422](#422)

### 🔍 Other Changes

- update insta snapshots to newer format by
[@jdx](https://github.com/jdx) in
[#429](#429)
- fix legacy inline snapshot format warnings by
[@jdx](https://github.com/jdx) in
[#433](#433)
- replace TODO with doc comment for subcommand_lookup by
[@jdx](https://github.com/jdx) in
[#434](#434)

### 📦️ Dependency Updates

- update actions/setup-node digest to 6044e13 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#419](#419)
- replace dependency @tsconfig/node22 with @tsconfig/node24 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#418](#418)
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 19, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [usage](https://github.com/jdx/usage) | minor | `2.12.0` → `2.13.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>jdx/usage (usage)</summary>

### [`v2.13.1`](https://github.com/jdx/usage/blob/HEAD/CHANGELOG.md#2131---2026-01-19)

[Compare Source](jdx/usage@v2.13.0...v2.13.1)

##### 🐛 Bug Fixes

- use correct PowerShell casing in enum variant by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;438](jdx/usage#438)

### [`v2.13.0`](https://github.com/jdx/usage/blob/HEAD/CHANGELOG.md#2130---2026-01-19)

[Compare Source](jdx/usage@v2.12.0...v2.13.0)

##### 🚀 Features

- **(release)** add LLM-generated prose summary to release notes by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;421](jdx/usage#421)
- add LLM-generated release notes for GitHub releases by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;423](jdx/usage#423)
- add spec lint command by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;430](jdx/usage#430)
- add PowerShell completion support by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;431](jdx/usage#431)

##### 🐛 Bug Fixes

- replace unsafe path unwrap chains with proper error handling by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;424](jdx/usage#424)
- pass positional args through to executed scripts by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;425](jdx/usage#425)
- replace unimplemented!() with proper errors for unsupported shells by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;432](jdx/usage#432)
- update claude CLI model and add bypassPermissions by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;435](jdx/usage#435)

##### 🚜 Refactor

- remove unused double-shebang support by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;426](jdx/usage#426)
- replace once\_cell with std::sync::LazyLock by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;428](jdx/usage#428)
- improve code quality with safety and lint fixes by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;427](jdx/usage#427)

##### ⚡ Performance

- use Arc for flag/arg keys in ParseOutput to reduce cloning by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;422](jdx/usage#422)

##### 🔍 Other Changes

- update insta snapshots to newer format by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;429](jdx/usage#429)
- fix legacy inline snapshot format warnings by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;433](jdx/usage#433)
- replace TODO with doc comment for subcommand\_lookup by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;434](jdx/usage#434)

##### 📦️ Dependency Updates

- update actions/setup-node digest to [`6044e13`](jdx/usage@6044e13) by [@&#8203;renovate\[bot\]](https://github.com/renovate\[bot]) in [#&#8203;419](jdx/usage#419)
- replace dependency [@&#8203;tsconfig/node22](https://github.com/tsconfig/node22) with [@&#8203;tsconfig/node24](https://github.com/tsconfig/node24) by [@&#8203;renovate\[bot\]](https://github.com/renovate\[bot]) in [#&#8203;418](jdx/usage#418)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44NC4yIiwidXBkYXRlZEluVmVyIjoiNDIuODQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments