-
Notifications
You must be signed in to change notification settings - Fork 294
fix: fix showCount props is invalid in alipay #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix showCount props is invalid in alipay #3366
Conversation
Walkthrough在 Taro 版 Textarea 调用处新增 showCount 属性透传至底层 Taro Textarea。现有字符计数的条件渲染保持不变,无控制流调整;对外导出或公共声明未变更。 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3366 +/- ##
==========================================
Coverage 88.15% 88.15%
==========================================
Files 291 291
Lines 19212 19212
Branches 2988 2988
==========================================
Hits 16937 16937
Misses 2269 2269
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fix: fix showCount props is invalid in alipay (#3366) * feat: 添加部分组件无障碍功能支持 - button - Checkbox - Countdown - Empty - Image - InputNumber - Price - Progress - NavBar - NoticeBar - Radio - Switch - Tabbar - Tabs - Toast * Revert "feat: 添加部分组件无障碍功能支持" This reverts commit 2e7cbd2. * feat: 添加组件无障碍功能支持 - button - Checkbox - Popup - Dialog - Overlay - Radio - Switch - Toast * fix: update * fix: update * fix: update * fix: update Overlay --------- Co-authored-by: ryanwang <[email protected]>
* fix(badge): 解决中文偏上问题 * fix: css 变量更新 * fix: 更正正黑字体 * fix: 更正正黑字体 * feat: 更新字体版本 * fix: fix showCount props is invalid in alipay (#3366) * feat(price): dynamic和harmony结构保持一致 * feat(ascf): 支持ASCF鸿蒙元服务 (#3402) Co-authored-by: ext.liuweijian3 <[email protected]> * fix(steps): taro版本div标签替换成view标签 --------- Co-authored-by: ryanwang <[email protected]> Co-authored-by: 2extliuweijian32 <[email protected]> Co-authored-by: ext.liuweijian3 <[email protected]>
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
Relation Taro TextArea Issue
☑️ 请求合并前的自查清单
Summary by CodeRabbit