-
Notifications
You must be signed in to change notification settings - Fork 30
Fetch #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fetch #22
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e8b6c59
Translated 'sever.js'
9470b2a
Translate 'task.md'
27af43f
Translate 'solution'
d9a9d01
Translate 'test.js'
835aaba
Translated 'source.js'
363bc8e
Translated 'article.md'
625b23f
Correct 'article.md'
61c7794
Translate 'article.md'
7333597
Reword 'article.md'
c178a41
Translate 'server.js'
52f7556
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
mitroc 3b71594
Apply suggestions from code review
3adf2cd
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
mitroc 5d606ab
Merge branch 'master' of https://github.com/mitroc/pl.javascript.info
mitroc ae0d66f
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
mitroc c20bed7
Apply code review suggestions
mitroc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
|
||
async function getUsers(names) { | ||
/* your code */ | ||
/* twój kod */ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
# Fetch users from GitHub | ||
# Pobierz użytkowników z GitHuba | ||
|
||
Create an async function `getUsers(names)`, that gets an array of GitHub logins, fetches the users from GitHub and returns an array of GitHub users. | ||
Stwórz asynchroniczną funkcję `getUsers(names)`, która otrzymuje tablicę z loginami do GitHuba, a następnie zwraca tablicę z odpowiadającymi im użytkownikami. | ||
|
||
The GitHub url with user information for the given `USERNAME` is: `https://api.github.com/users/USERNAME`. | ||
Informacje o użytkowniku przypisanym do `USERNAME`, znajdują się pod adresem: `https://api.github.com/users/USERNAME`. | ||
|
||
There's a test example in the sandbox. | ||
W naszym środowisku izolowanym znajduje się przykład testowy. | ||
|
||
Important details: | ||
Ważne informacje: | ||
|
||
1. There should be one `fetch` request per user. | ||
2. Requests shouldn't wait for each other. So that the data arrives as soon as possible. | ||
3. If any request fails, or if there's no such user, the function should return `null` in the resulting array. | ||
1. Można wykonać tylko jedno żądanie `fetch` o dane użytkownika. | ||
2. Żądania nie powinny na siebie oczekiwać. Chodzi o to, aby dane dotarły jak najszybciej. | ||
3. Jeżeli żądanie się nie powiedzie lub nie będzie użytkownika o podanej nazwie, funkcja powinna zwrócić `null` w tablicy wynikowej. |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.