Skip to content

Conversation

LorenzoBloedow
Copy link

If you use a static seed in your code, all tests will pass, because technically the seed is the same, however, the input changed so it shouldn't be the same.

Example of a static seed:
Screenshot 2025-09-06 at 7 25 12 AM

And here's the actual seed being used:
Screenshot 2025-09-06 at 7 25 34 AM

With the current code, both solutions will pass even if the input changes.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Sep 6, 2025
@javascript-translate-bot javascript-translate-bot requested a review from a team September 6, 2025 10:26
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2025

CLA assistant check
All committers have signed the CLA.

@smith558 smith558 requested a review from Copilot September 26, 2025 11:17
@smith558 smith558 self-assigned this Sep 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a test case for pseudo-random generators to ensure proper validation of seed consistency. The test was previously insufficient as it only verified that generators with the same seed produce identical outputs, but failed to test that generators with different seeds produce different outputs.

  • Adds generators with different seeds to verify they produce different outputs
  • Includes assertion to ensure generators with different seeds don't produce identical results

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed Review needed, please approve or request changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants