-
Notifications
You must be signed in to change notification settings - Fork 331
Track EVM stack "end" instead of "top" #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 175 175
Lines 19673 19674 +1
=======================================
+ Hits 18599 18600 +1
Misses 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Seems no performance regressions: Zen2, clang-18: |
35df236 to
fdfdaaa
Compare
pdobacz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise LGTM, but what does this accomplish? (put in the pr description too)
This is more correct C++ because it avoids the "bottom" pointer (one below the stack space base pointer). In C++ only pointers to the elements of an array and the "end" pointers are well defined.
This also potentially helps with the "overaligned" stack space optimization. To be continued...