Export state tests with invalid txs

[pdobacz]

I'm branching off of eof-create4, as this is where a bunch of exportable invalid tx tests were added.

I also tackled a "// TODO: Compare states carefully, they should be identical." for invalid txs - the same state comparison logic is executed now. This required a tiny amount of shuffling in how the default expectations on accounts like sender and coinbase work, but I think this is acceptable

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (ad99657) to head (65bbf0a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   98.32%   98.37%   +0.05%     
==========================================
  Files         129      129              
  Lines       15525    15536      +11     
==========================================
+ Hits        15265    15284      +19     
+ Misses        260      252       -8     

Flag	Coverage Δ
statetests	27.77% <20.00%> (-0.01%)	⬇️
statetests-silkpre	18.81% <20.00%> (+<0.01%)	⬆️
unittests	94.17% <100.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
test/statetest/statetest_runner.cpp	96.87% <100.00%> (+0.32%)	⬆️
test/unittests/state_transition.cpp	98.38% <100.00%> (+0.03%)	⬆️
test/unittests/state_transition.hpp	0.00% <ø> (ø)
...est/unittests/state_transition_eof_create_test.cpp	100.00% <100.00%> (ø)
test/unittests/state_transition_tx_test.cpp	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[pdobacz]

Ready to review after rebase

[gumb0]

These are not the right error messages that are normal in tests.
Example of valid one: https://github.com/ethereum/tests/blob/1c23e3c27ac53b794de0844d2d5e19cd2495b9d8/GeneralStateTests/stExample/invalidTr.json#L26

Perhaps some conversion needed similar to https://github.com/ethereum/evmone/blob/9b3ee17421d0f9ed2da555adef7ed81464566e7d/test/unittests/eof_validation.cpp#L14

The good place to find test error messages is probably retesteth config https://github.com/ethereum/retesteth/blob/fa5fe40627b0b4914295d5d0fe120dd0b053cd15/retesteth/configs/clientconfigs/evmone.cpp#L231

[pdobacz]

@gumb0 Thanks for flagging this! So to be sure, what I need to do is:

• PR retesteth to add the additional entries
• in this spot, call a new function like get_tests_error_message(std::error_code), instead of just .message() which has clauses like:

            case INIT_CODE_EMPTY:
                return "TR_InitcodeEmpty";   // <<<<<- one of the new `TR_` entries

to translate the code into retesteth-compatible value?

[gumb0]

yes, sounds good