Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Mar 6, 2025

Pre-computing the lines for the Miller loop in the BLS pairing check don't improve performance because the lines are used only once.

@chfast chfast added precompiles Related to EVM precompiles has_dependencies PR depends on not merged yet PR labels Mar 6, 2025
@chfast chfast requested a review from rodiazet March 6, 2025 15:16
Base automatically changed from precompiles/bls_cleanup to master March 6, 2025 15:36
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (94818d7) to head (5820deb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   94.54%   94.54%   -0.01%     
==========================================
  Files         167      167              
  Lines       18234    18231       -3     
==========================================
- Hits        17239    17236       -3     
  Misses        995      995              
Flag Coverage Δ
eof_execution_spec_tests 22.49% <0.00%> (+<0.01%) ⬆️
ethereum_tests 28.32% <0.00%> (+<0.01%) ⬆️
ethereum_tests_silkpre 21.00% <0.00%> (+<0.01%) ⬆️
execution_spec_tests 20.97% <100.00%> (-0.02%) ⬇️
unittests 89.76% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone_precompiles/bls.cpp 98.08% <100.00%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pre-computing the lines for the Miller loop in the BLS pairing check
don't improve performance because the lines are used only once.
@chfast chfast force-pushed the precompiles/bls_drop_lines_precomp branch from 8d878de to 5820deb Compare March 6, 2025 15:44
@chfast chfast enabled auto-merge (squash) March 6, 2025 15:45
@chfast chfast merged commit 8c4d290 into master Mar 6, 2025
23 checks passed
@chfast chfast deleted the precompiles/bls_drop_lines_precomp branch March 6, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has_dependencies PR depends on not merged yet PR precompiles Related to EVM precompiles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants