EIP-7873: EOF - TXCREATE and InitcodeTransaction type #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44436bc to
b9c0734
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
+ Coverage 94.48% 94.91% +0.43%
==========================================
Files 170 171 +1
Lines 18026 19640 +1614
==========================================
+ Hits 17032 18642 +1610
- Misses 994 998 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
be436a5 to
1056b16
Compare
5358ba4 to
22d63d2
Compare
pdobacz
approved these changes
Mar 17, 2025
fbe305e to
5a49ebe
Compare
9428ee6 to
6042c28
Compare
2de672f to
1cea026
Compare
5a49ebe to
13dfa85
Compare
741b8a9 to
b46a59e
Compare
Co-authored-by: pdobacz <[email protected]>
Co-authored-by: Andrei Maiboroda <[email protected]>
chfast
reviewed
Apr 8, 2025
|
|
||
| private: | ||
| evmc_tx_context m_tx = {}; | ||
| std::optional<std::unordered_map<evmc::bytes32, bytes_view>> m_initcodes; |
Member
There was a problem hiding this comment.
Will it fly if we omit std::optional (empty map meaning no initcodes)?
Member
Author
There was a problem hiding this comment.
I think this is optimization to avoid calling get_tx_context().initcodes on every get_tx_initcode_by_hash().
So it will work without optional, but for no initcodes it will check tx_context.initcodes_count on every TXCREATE (will not query the host though, thanks to cached tx_context).
| stack.push(0); // Assume failure. | ||
| state.return_data.clear(); | ||
|
|
||
| if (!check_memory(gas_left, state.memory, input_offset_u256, input_size_u256)) |
Member
There was a problem hiding this comment.
This is weird that memory check happens after we push 0 to the stack. Please check this.
Member
Author
There was a problem hiding this comment.
It's the same as what CREATE* is doing (stack is not observable after OOG)
test/state/state.cpp
Outdated
| return make_error_code(INIT_CODE_COUNT_LIMIT_EXCEEDED); | ||
| if (tx.initcodes.empty()) | ||
| return make_error_code(INIT_CODE_COUNT_ZERO); | ||
| if (std::any_of(tx.initcodes.begin(), tx.initcodes.end(), |
pdobacz
approved these changes
Apr 9, 2025
chfast
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.