Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Sep 25, 2024

We are going to hide the State in state.hpp from public. This change moves other types out of this file make the future transition easier to control.

The git history is preserved by using file renames and a lot of merge commits (octopus merge didn't work for me).

We are going to split transaction-related types out of state.hpp.
This change is to preserve the git history of these types.
We are going to split block-related types out of state.hpp.
This change is to preserve the git history of these types.
@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.21%. Comparing base (bd5dfab) to head (db1a5ef).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
test/state/transaction.cpp 94.11% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1031   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         149      153    +4     
  Lines       15927    15927           
=======================================
  Hits        15005    15005           
  Misses        922      922           
Flag Coverage Δ
eof_execution_spec_tests 17.52% <59.61%> (ø)
ethereum_tests 27.33% <96.15%> (ø)
ethereum_tests_silkpre 19.14% <28.84%> (ø)
execution_spec_tests 20.44% <92.30%> (ø)
unittests 89.01% <96.15%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/blockchaintest/blockchaintest.hpp 0.00% <ø> (ø)
test/state/block.cpp 100.00% <100.00%> (ø)
test/state/block.hpp 100.00% <100.00%> (ø)
test/state/bloom_filter.cpp 100.00% <ø> (ø)
test/state/host.hpp 100.00% <ø> (ø)
test/state/mpt_hash.cpp 100.00% <ø> (ø)
test/state/state.cpp 100.00% <ø> (+0.76%) ⬆️
test/state/state.hpp 100.00% <ø> (ø)
test/state/system_contracts.cpp 100.00% <ø> (ø)
test/state/transaction.hpp 100.00% <100.00%> (ø)
... and 2 more

@chfast chfast merged commit 754b4c1 into master Sep 26, 2024
@chfast chfast deleted the state/split-block-tx branch September 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants