Spec out behavior of legacy CREATE/CREATE2 w/ eof initcode #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Where is this case covered? |
Member
Author
This one has already been covered, line 132 https://github.com/ipsilon/eof/pull/53/files#diff-2d261f5a273360a59dd4eb4fe19a4d09bab338cfb2b65660d4a2e3e428c175f1R132 |
gumb0
reviewed
Feb 6, 2024
| - If instructions `CREATE` and `CREATE2` have EOF code as initcode (starting with `EF00` magic) | ||
| - deployment fails (returns 0 on the stack) | ||
| - caller's nonce is not updated and gas for initcode execution is not consumed | ||
| - `DELEGATECALL` from an EOF contract to a legacy contract is disallowed, and it returns 0 to signal failure. We allow legacy to EOF path for existing proxy contracts to be able to use EOF upgrades. |
Member
There was a problem hiding this comment.
I would maybe either move the rule about the legacy tx with EOF initcode being invalid here from Transaction Types section, or even duplicate it here, but up to you.
Member
Author
There was a problem hiding this comment.
makes sense, it's not that much related to the new tx type
Member
Author
There was a problem hiding this comment.
I've also moved the note on EIP-3541 out of the list to a NOTE, as it is not a modification of behavior
gumb0
approved these changes
Feb 6, 2024
8d31dab to
be1c5dd
Compare
be1c5dd to
66cf1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the end game should be:
0xEF00in legacy creation tx (indata) - invalid tx0xEFdeploy from legacy creation tx - abort (eip-3541)0xEF00sent to CREATE / CREATE2 - soft fail0xEFreturned from CREATE / CREATE2 - abort (eip-3541)I think now the megaspec covers all these cases