Removed _POSIX_C_SOURCE defines where _GNU_SOURCE was also defined, as _GNU_SOURCE implicitly defines _POSIX_C_SOURCE#221
Merged
thiagomacieira merged 1 commit intointel:mainfrom Jun 28, 2022
Conversation
…so defined, as `_GNU_SOURCE` implicitly defines `_POSIX_C_SOURCE`, but on BSD/macOS, `_POSIX_C_SOURCE` prevents non-POSIX extensions from being defined.
Member
|
Makes sense, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220.
As explained in #220, on macOS/BSD,
#define _POSIX_C_SOURCEsupersedes#define _GNU_SOURCEand prevents the GNU extensionasprintffrom being defined, which causes a compile error injson2cbor.c. To fix this, we can simply remove the#define _POSIX_C_SOURCE 200809L, as#define _GNU_SOURCEimplies it, but without the superseding behavior seen on macOS/BSD.Specifically, according to https://man7.org/linux/man-pages/man7/feature_test_macros.7.html,