fix(pkg/cosmosanalysis): support App with generics #2602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tbruyelle thank you for working on this! |
Member
|
It looks good, nice work 👍. I tested it locally too. |
jeronimoalbi
previously approved these changes
Jul 11, 2022
jeronimoalbi
approved these changes
Jul 12, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* fix(pkg/cosmosanalysis): support App with generics * test: turn into parametized test and use embed for file content Co-authored-by: jeronimoalbi <jeronimo.albi@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2590
The fix is to expect a wider range of AST types, due to the usage of generics.
Sorry @ilgooz I missed that the issue has already been assigned to you, I hope this is fine.