Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder_color #35

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add placeholder_color #35

wants to merge 4 commits into from

Conversation

luyu-wu
Copy link

@luyu-wu luyu-wu commented Feb 21, 2024

Added placeholder_color configuration option that changes placeholder text color!
Hopefully everything is ok and I can become a more major contributer to Hypr stuff in the future (I got pretty moved by the blogpost).
Honestly the implementation is sketch af though, although it works on all cases I've tested it.

@vaxerski
Copy link
Member

placeholder text can already be changed with pango markup

@matt1432
Copy link

matt1432 commented Mar 3, 2024

placeholder text can already be changed with pango markup

I feel like this would be a nice abstraction instead of having to do pango markup. I personally had to go through issues to figure it out. (that might be a skill issue on my part but still)

@vaxerski
Copy link
Member

vaxerski commented Mar 3, 2024

it's clear in the docs even with a link?

@plurpio
Copy link

plurpio commented Mar 4, 2024

this could be useful as "authentication failed" doesn't use pango markdown

@vaxerski
Copy link
Member

vaxerski commented Mar 4, 2024

I'd prefer configuring the text there and not color

@bvr-yr
Copy link
Contributor

bvr-yr commented Mar 4, 2024

what about adding fail_color instead
and maybe on failure change both placeholder and outer color?

one problem with fail placeholder color being inverted, like it is now:
if i use #1b1b1b and #e4e4e4 it's invisible
it's ok for grayish background, but not if fg/bg are nearly inverted by themselves

@vaxerski
Copy link
Member

vaxerski commented Mar 4, 2024

color change for the outer color = ok, but again I'd prefer a configurable text for fail rather than color

@bvr-yr
Copy link
Contributor

bvr-yr commented Mar 4, 2024

u mean just use markup like for normal placeholder?

@vaxerski
Copy link
Member

vaxerski commented Mar 4, 2024

mhm

@bvr-yr
Copy link
Contributor

bvr-yr commented Mar 4, 2024

gonna look at it later
i suppose it is possible to extract parsed color to reuse?

@vaxerski
Copy link
Member

vaxerski commented Mar 4, 2024

dont think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants