Skip to content

Removing this.options.htmlhint || {} from options #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removing this.options.htmlhint || {} from options #14

wants to merge 1 commit into from

Conversation

willpracht
Copy link

Attempting to extend defaults with this.options.htmlhint before this.options is defined.

Removing this line as I didn't see any other references to it in the script.

This will fix #13.

@mattlewis92 Please let me know if I'm missing the intent of this and I can update the PR to reflect.

Thanks!

Attempting to extend defaults with `this.options.htmlhint` before `this.options` is defined.

Removing this line as I didn't see any other references to it in the script.

This will fix #13.
@willpracht willpracht closed this Mar 5, 2018
@willpracht
Copy link
Author

@mattlewis92 Looks like this.options.htmlhint is used in the tests at least. Closing this PR, and I'll defer to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wepback 4.0.0 compatiblity
1 participant