Main v0.0.85 #16
Main v0.0.85 #16
Conversation
…-import add missing import asyncio
…exible-auth Support additional authentication mechanisms for AWS services
Speechmatics TTS connection issue
…rt-pcc-docker Update quickstart to use pcc docker command
…nd-dtmf DailyTransport: fix sending DTMF tones
Some implementations were returing a list and some were returning a JSON string. They should all return a list and the user would decide if it wants to transform that into JSON.
Cartesia: update speed InputParam
…ssages-for-logging unify get_messages_for_logging()
…version-check RTVIProcessor: make check sure client version is set
…k-wait-for-startframe PipelineTask: wait for StartFrame to reach end of pipeline
…-0.19.8 pyproject: update daily-python to 0.19.8
This lets a text frame bypass TTS while still being included in the LLM context. Useful for cases like structured text that isn’t meant to be spoken but should still contribute to context.
…ls-and-bug-fix `LLMContext` evals and bug fix
Updating the README to reflect that:
…ic-pre-load-cue AWSNovaSonicLLMService: pre-load audio cue in the constructor
…ce-cloning feat: add voice cloning and speaking rate to GoogleTTSService
…ription-frame-support adds support to Azure STT for creating InterimTranscriptFrames
Only set last_frame_time when handling OutputAudioRawFrame
…terruption-unit-test MinWordsInterruptionStrategy unit test
Add to, from phone info and custom data to the development runner
update CHANGELOG for 0.0.85
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| async def force_cancel(self): | ||
| """Forcefully cancel the task and any running subtasks.""" | ||
| logger.debug(f"Force canceling task {self} triggered") | ||
| try: | ||
| await self.cancel() | ||
| except Exception as e: | ||
| logger.warning(f"Error calling pipecat task cancel {self}: {e}") | ||
|
|
||
| for task in self._task_manager.current_tasks(): | ||
| try: | ||
| await self._task_manager.cancel_task(task) | ||
| except Exception as e: | ||
| logger.warning(f"Error canceling task {self}: {e}") |
There was a problem hiding this comment.
[P1] Force cancellation still waits on regular cancel
force_cancel() immediately awaits self.cancel(), which itself waits up to _cancel_timeout_secs for a CancelFrame to propagate before returning. In the very scenario this helper is meant to solve—an unresponsive pipeline—the method will still block for the full cancel timeout and only then iterate the remaining tasks. The subsequent loop therefore never runs promptly and force_cancel() provides no advantage over calling cancel(). Consider issuing the regular cancel asynchronously or with a very short timeout before cancelling the remaining tasks.
Useful? React with 👍 / 👎.
Description
force_cancelmodule to work with bot code (1 commit from Laila)