Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(csp) add missing directives / keywords #4191

Merged
merged 3 commits into from
Mar 11, 2025
Merged

enh(csp) add missing directives / keywords #4191

merged 3 commits into from
Mar 11, 2025

Conversation

probil
Copy link
Contributor

@probil probil commented Dec 24, 2024 •
edited
Loading

Adds missing CSP directives

Changes

Added missing CSP directives as per MDN documentation:

Checklist

  • Added markup tests
  • Updated the changelog at CHANGES.md

@probil probil force-pushed the add-missing-csp-directives branch 2 times, most recently from 8611220 to b43b8b7 Compare December 30, 2024 15:23
@probil probil force-pushed the add-missing-csp-directives branch from b43b8b7 to c1ee680 Compare March 11, 2025 19:01
@probil probil force-pushed the add-missing-csp-directives branch from ed9cd0d to df0765c Compare March 11, 2025 19:08
@probil
Copy link
Contributor Author

probil commented Mar 11, 2025 •
edited
Loading

Hey @joshgoebel
I'm not sure whether I'm supposed to request the review explicitly or not (sorry if not, first time contributing here). I've just applied latest changes and it should be a quick review for you. Let me know if any additional changes are needed.
Thanks

@github-actions GitHub Actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +92 B

View Changes
file base pr diff
es/core.min.js 8.19 KB 8.19 KB +2 B
es/highlight.min.js 8.19 KB 8.19 KB +2 B
es/languages/csp.min.js 390 B 433 B +43 B
highlight.min.js 8.23 KB 8.23 KB +2 B
languages/csp.min.js 399 B 442 B +43 B

@joshgoebel joshgoebel merged commit 5685c0e into highlightjs:main Mar 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@probil @joshgoebel