Update buildSizeReport.js #4153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error Handling: Added try-catch blocks around key operations like reading files and compression. Code Structure: Modularized functions for better readability and maintainability. Clarity in Reporting: The report sections (Added, Removed, and Changed) are clear and concise with the markdown formatted properly. Performance: Simplified some of the operations to reduce unnecessary complexity, e.g., computeFileSize directly handles errors instead of causing the script to fail.
|
While I actually do prefer some of the code changes made here, there are a lot of other changes I do not like. Filtering out the desired parts from the rest just isn't worth the time. Please do not submit any further general "code improvement/cleanup" type PRs. As I suggested before, please find an existing issue that needs to be fixed and start there. Here are the issue tagged "good first issue", you could have a look thru those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Handling: Added try-catch blocks around key operations like reading files and compression.
Code Structure: Modularized functions for better readability and maintainability.
Clarity in Reporting: The report sections (Added, Removed, and Changed) are clear and concise with the markdown formatted properly.
Performance: Simplified some of the operations to reduce unnecessary complexity, e.g., computeFileSize directly handles errors instead of causing the script to fail.
Checklist
CHANGES.md