Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hljs function #4150

Closed
wants to merge 1 commit into from
Closed

Conversation

TusharNaugain
Copy link

@TusharNaugain TusharNaugain commented Oct 23, 2024

This pull request introduces the HLJS function, which sets up the essential components of the Highlight.js library. It includes storage for registered languages and aliases, the ability to handle plugins for extensibility, and a safe mode flag to control unsafe operations

Changes

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

This pull request introduces the HLJS function, which sets up the essential components of the Highlight.js library. It includes storage for registered languages and aliases, the ability to handle plugins for extensibility, and a safe mode flag to control unsafe operations
@joshgoebel
Copy link
Member

Ok, thanks truly for finally a small, readable PR. But...

These types of changes are not desired or helpful.

  • We have very different opinions about how comments should be used.
  • You continue to remove type information.
  • You changed an error message [removing half of it] for no stated reason.

As I suggested before, perhaps find an existing issue that needs to be fixed and start there. Here are the issue tagged "good first issue", you could have a look thru those.

https://github.com/highlightjs/highlight.js/issues?q=is%3Aissue+is%3Aclosed+label%3A%22good+first+issue%22

@joshgoebel joshgoebel closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants