chore: fix how we set channels in s3 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, each subsequent tarball contained the contents of each previous tarball.
rlmestre
approved these changes
Apr 5, 2025
dwelch2344
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few quirks with how we were uploading to s3:
Ensures we use a short commit hash in the
oclif promote --sha=<short-hash>to meet oclif's expectationsEnsure the darwin and linux tarballs don't contain the contents of the other tarballs by using
--parallelEnsure the channel used by oclif can be beta even if we're not doing a dry run
Green CI Run
Screenshot showing beta channel in s3
