feat: batch api requests #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API errors with `request entity too large` when there are thousands of purls. WIP because this still doesn't work with node 18 for some reason.
Add logging. Still broken on node 18.
Set limit to 1000 purls per request.
aavorthmann
approved these changes
Mar 31, 2025
dwelch2344
approved these changes
Apr 1, 2025
marco-ippolito
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Scan eol fails on any Node version when dealing with thousands of purls
Cause: large lists of purls (several thousand lines) exceeds the BE request entity limit.
Solution: batch requests using
Promise.allSettledand combine the results.