Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: guide on custom jwt auth integration (close #4441) #4442

Conversation

marionschleifer
Copy link
Contributor

Description

An integration guide for custom JWT auth server.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Docs

@netlify
Copy link

netlify bot commented Apr 16, 2020

Deploy preview for hasura-docs ready!

Built with commit f6d713a

https://deploy-preview-4442--hasura-docs.netlify.app

@tirumaraiselvan
Copy link
Contributor

tirumaraiselvan commented Apr 16, 2020

While we are at this, can we have a separate section for Integration with auth providers similar to Integration with monitoring tools. (i.e. break out the current Integration/migration tutorials)

Will need to keep in mind the urls etc are not breaking.

@GavinRay97
Copy link
Member

@tirumaraiselvan

When you say keeping a separate section for integration, do you mean visually separating the content for this?

My thought would be to put a basic bare-bones Node JWT bcrypt auth implementation in the docs somewhere near where people would be looking (in the same area that the Auth0 and Firebase guides are currently, maybe?).

@tirumaraiselvan
Copy link
Contributor

@GavinRay97 What i meant was making an item called Integration with auth and taking the already present things (including this issue) into that section (or renaming the current title and moving the non-auth things into a different section).

Screen Shot 2020-04-17 at 1 36 47 PM

@rikinsk @marionschleifer Thoughts?

Also, as for the current issue, have you seen this PR: #848

@marionschleifer
Copy link
Contributor Author

marionschleifer commented Apr 17, 2020

@tirumaraiselvan thank you for the input. I'll discuss with @rikinsk in our docs catch-ups.

Meanwhile, @GavinRay97 you can just focus on writing the guide in the file that I created in this PR. I'll take care of the structure in the review 🙂

@GavinRay97
Copy link
Member

You got it 👍

@marionschleifer
Copy link
Contributor Author

Closing this, as we'll add this as part of a larger auth docs refactoring PR.

@hasura-bot
Copy link
Contributor

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/docs Related to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants