Skip to content

A couple copy improvements #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

A couple copy improvements #5893

merged 2 commits into from
Mar 17, 2025

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented Mar 17, 2025

See the individual commits

lutter added 2 commits March 17, 2025 12:26
Generally, it makes no sense to copy failed deployments, but when
deployments need to be moved to different shards, it does.
Pruning during copying can cause the copy to fail because data it needs
disappears during copying.
@lutter lutter requested a review from zorancv March 17, 2025 12:51
Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a small uncertainty it looks good.

@lutter lutter merged commit 8a8b428 into master Mar 17, 2025
6 checks passed
@lutter lutter deleted the lutter/copy branch March 17, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants