reviewed list of gradle books - proposal for books.md #111
reviewed list of gradle books - proposal for books.md #111oleg-nenashev merged 4 commits intogradle:mainfrom
Conversation
oleg-nenashev
left a comment
There was a problem hiding this comment.
Thanks for the patch @ivonasto! We can merge the first version without the images, but we will still need books.html to be added to the page. Also, please add the page to the navigation under the Resources section
|
Hi @ivonasto , do you plan to finish this PR? Or is any help needed? |
|
Hi, @oleg-nenashev. Yes, I will finish it. I have trouble with the dev container, almost got it working. I have more time now to look into it. Thank you |
|
Sure. If you need any help with sorting the issue, just ask on the #docs or #contributing Slack channels |
|
Hello, I did the preliminary version. If you have any visual or code suggestions, please let me know. Could you upload the book covers so I can replace the placeholder image? |
|
Since it is deployed from the |
oleg-nenashev
left a comment
There was a problem hiding this comment.
Thank you @ivonasto ! Just a few items before we can merge
- Could you please add authors to the metadata and visualization? Just a name would be good enough, Author+URL would be better
- The cover images will need some approvals. I suggest putting a default image for now, see below
mkdocs.yml
Outdated
| - Code of Conduct: dotgithub/CODE_OF_CONDUCT.md | ||
| - Social Media: resources/social-media.md | ||
| - Trademark and Branding: https://gradle.com/brand/ | ||
| - Book: resources/books.md |
There was a problem hiding this comment.
| - Book: resources/books.md | |
| - Books: resources/books.md |
oleg-nenashev
left a comment
There was a problem hiding this comment.
it looks good to me as an initial implementation, thank you! I will probably polish it a bit later so that there is no need to do HTML injection
Books metadata file with existing titles in English from the 2020 list in issue #98.
Images to be added.