playground: regenerate with GopherJS 1.12-2 and Go 1.12.13 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modify the default "hello world" snippet to use it, since it's a more general API. Modernize update.sh slightly to handle variability in environments better. Updates #69
Previously, the script relied on GOROOT not being user-writable and failed when that wasn't the case. This change makes it succeed in both cases. Fixes #69
GopherJS 1.12-2 has added support for syscall/js package, so it should be available as part of imports. The syscall/js API is not included in the GOROOT/api/go1.*.txt files at this time, and so it needs to be added to mkstdlib.go explicitly. Use the mkapi.go program to determine the syscall/js API. Regenerate zstdlib.go with the updated generator, using Go 1.12.13: go1.12.13 generate github.com/gopherjs/gopherjs.github.io/playground/internal/imports Updates golang/go#27590
Done on darwin/amd64 environment. Regenerated with: go get golang.org/dl/go1.12.13 go1.12.13 generate github.com/gopherjs/gopherjs.github.io/playground
|
I'm not familiar with the playground, so I'll defer this to @slimsag |
|
The playground doesn't really need much review (and we don't have much reviewer time available due to gopherjs/gopherjs#894), it just needs to continue to work. I've tested and will ensure it does. If someone spots a problem in one of the commits, let me know, otherwise I plan to merge later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add support for
syscall/jsand start using it in the initial snippet.Make various modernizations/improvements to the
update.shscript.Fixes #69.
/cc @hajimehoshi @slimsag
(See individual commits with descriptive commit messages.)