Skip to content

_config.yml: Don't explicitly specify markdown engine. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2016

Conversation

dmitshur
Copy link
Member

Fixes #49.

This is not tested. Done based on what the email said in #48 (comment), to remove specifying markdown option in the _config.yml.

I don't think we're using any subtle features, so the default markdown engine, whatever it may be, should be okay.

@neelance
Copy link
Member

Yeah. I'm okay with merging and then checking the output.

@dmitshur
Copy link
Member Author

Let's try. Will revert if I spot any issues.

dmitshur added a commit that referenced this pull request Feb 22, 2016
_config.yml: Don't explicitly specify markdown engine.
@dmitshur dmitshur merged commit a323f6d into master Feb 22, 2016
@dmitshur
Copy link
Member Author

I see some minor differences, but no major issues.

Before:

image

After:

image

The largest minor issue is that code blocks have a strange 0-width left padding.

image

@dmitshur dmitshur deleted the update-markdown-engine branch February 22, 2016 11:50
@dmitshur
Copy link
Member Author

On the plus side, no more warning email!

@dmitshur
Copy link
Member Author

FWIW, the HTML before:

image

And after:

image

@neelance
Copy link
Member

Seems like the CSS file needs an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants