Move fixed tests into their appropriate locations.#49
Merged
TristonianJones merged 2 commits intogoogle:masterfrom Feb 5, 2019
Merged
Move fixed tests into their appropriate locations.#49TristonianJones merged 2 commits intogoogle:masterfrom
TristonianJones merged 2 commits intogoogle:masterfrom
Conversation
gabrielsz
reviewed
Feb 5, 2019
Contributor
gabrielsz
left a comment
There was a problem hiding this comment.
Hi! They all look good. The only ask is to rename the first 2 tests (based on Jim's feedback on my own PRs), and remove 1 comment which I think should no longer apply
| value: { bool_value: false } | ||
| } | ||
| test { | ||
| name: "self_test_equals_mixed_types" |
Contributor
There was a problem hiding this comment.
Can you rename this test to eq_mixed_types?
| } | ||
| } | ||
| test { | ||
| name: "self_test_not_equals_data_type" |
Contributor
There was a problem hiding this comment.
Can you rename this test to not_eq_list_data_type?
| expr: "[1] == [1.0]" | ||
| disable_check: true # need to make it fail in the evaluation phase | ||
| eval_error: { | ||
| # Note: The type checker error shows (list(int), list(double)) instead |
Contributor
There was a problem hiding this comment.
This is now an implementation detail, should we remove it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move fixed tests out of
broken.textprotoand into their rightful homes.