-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/ast: don't MergeLine in SortImports when last import on the same line as RParen #69187
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 7d1789f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610035. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
This PR (HEAD: 3d0bf19) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610035. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-31T14:52:43Z","revision":"cb718863e186e6c2d38759d65f1e8ba208436227"} Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Mateusz Poliwczak: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
3d0bf19
to
70ce43c
Compare
This PR (HEAD: 70ce43c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610035. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-10-01T08:08:55Z","revision":"340b8d02a7fa389343e97949ab02c162ec75a924"} Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Mateusz Poliwczak: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Alan Donovan: Patch Set 3: Code-Review+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
70ce43c
to
af9eb3e
Compare
This PR (HEAD: af9eb3e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610035. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 4: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-10-02T09:12:55Z","revision":"d7585789f2b660f7d813d60bf9aec0a6c48a639d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Mateusz Poliwczak: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/610035. |
Fixes #69183