Align libobjc2 runtime function signatures with Apple’s documented API#374
Merged
davidchisnall merged 2 commits intognustep:masterfrom Feb 10, 2026
Merged
Conversation
…arLayout and class_setWeakIvarLayout to match Apple signatures
davidchisnall
approved these changes
Feb 10, 2026
Member
|
Thanks! The class things returning id annoyed me for ages, but Apple compatibility required it. I’m glad they’ve fixed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates several Objective-C runtime function signatures to match Apple’s documented API, as discussed in #122.
The changes are limited to type corrections and do not alter runtime behavior or ABI. In particular:
class_getIvarLayout,class_setIvarLayout, and their weak variants now useconst uint8_t *instead ofconst char *.objc_lookUpClassandobjc_getRequiredClassnow returnClassrather thanid,.Happy to adjust if there are preferred compatibility or annotation conventions.