gh-958: make positions_from_delta Array API compatible
#959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
commented
Jan 12, 2026
| np.testing.assert_array_less(actual, desired) | ||
|
|
||
| @staticmethod | ||
| def assert_equal(actual: AnyArray, desired: AnyArray) -> None: |
Member
Author
There was a problem hiding this comment.
Removing this as I tried to use it when I meant to use assert_array_equal
paddyroddy
commented
Jan 12, 2026
|
|
||
| pos = benchmark(function_to_benchmark) | ||
|
|
||
| lon, lat, cnt = data_transformer.catpos(pos, xp=np) |
Member
Author
There was a problem hiding this comment.
Changed this as it looks rude
paddyroddy
commented
Jan 12, 2026
paddyroddy
commented
Jan 12, 2026
| nside, | ||
| ipix, | ||
| lonlat=True, | ||
| rng=_utils.rng_dispatcher(xp=np), |
Member
Author
There was a problem hiding this comment.
randang internally uses numpy which means we have read-only issues. This change means we can get around it (but still rely on NumPy). We could move this to it's own module for healpix-changes
Member
Author
There was a problem hiding this comment.
Alternatively, @ntessore could randang be changed to accept random seeds?
paddyroddy
commented
Jan 12, 2026
connoraird
reviewed
Jan 12, 2026
Co-authored-by: Connor Aird <[email protected]>
2 tasks
connoraird
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the work towards #413, I'm working on #947. As part of the work I was porting the individual functions to the Array API, but it makes sense to do this in one step first.
Closes: #958, #907
Changelog entry
Changed: Make
positions_from_deltaArray API compatibleChecks