Skip to content

Migrate to sqlite#2

Closed
mittalyashu wants to merge 47 commits intodevfrom
feature/switch-to-sqlite
Closed

Migrate to sqlite#2
mittalyashu wants to merge 47 commits intodevfrom
feature/switch-to-sqlite

Conversation

@mittalyashu
Copy link
Member

Currently, we are using vuex to store data inside the states.

@mittalyashu mittalyashu added ⚙ Improvement New feature or request discussion labels May 2, 2019
@mittalyashu mittalyashu self-assigned this May 2, 2019
@mittalyashu mittalyashu added 💡 Feature and removed ⚙ Improvement New feature or request 💡 Feature labels May 5, 2019
@mittalyashu mittalyashu added the help wanted Extra attention is needed label Jun 9, 2019
@gitthermal gitthermal deleted a comment Jul 14, 2019
@mittalyashu mittalyashu added the 🏃🏻‍♀️ Priority medium Remember to work on this label Jul 24, 2019
@ghost
Copy link

ghost commented Aug 3, 2019

ESLint detected 22 issues on 132963b
Visit https://sider.review/gh/repos/183869437/pulls/2 to review the issues.

posted by Sider

postinstall command install all the electron app native deps.
@ghost
Copy link

ghost commented Aug 5, 2019

ESLint analysis of 66aebbb failed.
Visit the analysis results page to review error log.

posted by Sider

@ghost
Copy link

ghost commented Aug 5, 2019

stylelint analysis of 66aebbb failed.
Visit the analysis results page to review error log.

posted by Sider

@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
@gitthermal gitthermal deleted a comment Aug 5, 2019
FROM repository
INNER JOIN gitRepository USING(repositoryId)`,
(err, data) => {
if (err) console.log(err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ESLint] Warning - Unexpected console statement. (no-console) (link)

posted by Sider

(err, data) => {
if (err) console.log(err);
else {
console.log(data);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ESLint] Warning - Unexpected console statement. (no-console) (link)

posted by Sider

);
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ESLint] Warning - Insert ; (prettier/prettier) (link)

posted by Sider

);
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ESLint] Warning - Missing semicolon. (semi) (link)

posted by Sider

FROM repository
INNER JOIN gitRepository USING(repositoryId)`,
(err, data) => {
if (err) console.log(err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ESLint] Warning - Unexpected console statement. (no-console) (link)

posted by Sider

$repositoryId: data.repositoryId
},
(err, data) => {
if (err) console.log("err", err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ESLint] Warning - Unexpected console statement. (no-console) (link)

posted by Sider

@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
@gitthermal gitthermal deleted a comment Oct 7, 2019
Switch from vuex to sqlite database.
$commandId: commandId
},
err => {
if (err) console.log(err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ESLint] Warning - Unexpected console statement. (no-console) (link)

posted by Sider

$path: path
},
err => {
if (err) console.log(err);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ESLint] Warning - Unexpected console statement. (no-console) (link)

posted by Sider

@gitthermal gitthermal deleted a comment Oct 8, 2019
@mittalyashu mittalyashu removed the help wanted Extra attention is needed label Oct 8, 2019
@mittalyashu mittalyashu changed the base branch from master to dev October 11, 2019 01:39
@mittalyashu
Copy link
Member Author

Closing this PR against #3577

@mittalyashu mittalyashu deleted the feature/switch-to-sqlite branch October 11, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙ Improvement New feature or request 🏃🏻‍♀️ Priority medium Remember to work on this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant