Merged
Conversation
YiMysty
approved these changes
Jan 12, 2022
tcbyrd
reviewed
Jan 12, 2022
tcbyrd
reviewed
Jan 12, 2022
Co-authored-by: Tommy Byrd <[email protected]>
Contributor
Author
|
Gonna merge this in, will open a new pr with the tagging bit of the work |
parkr
reviewed
Jan 14, 2022
Contributor
parkr
left a comment
There was a problem hiding this comment.
Some quick comments for your next PR!
|
|
||
| # check that gh is installed and logged in | ||
|
|
||
| gh auth status -h github.com |
Contributor
There was a problem hiding this comment.
Since this is before the set -e, if it fails it won't stop the script from running.
| # first get the sha of main for each repo | ||
|
|
||
| gh_pages_sha = gh api repos/github/pages/git/refs/heads/master | jq '. | .object.sha' | ||
| jekyll_sha = gh api repos/actions/jekyll-build-pages/git/refs/heads/main | jq '. | .object.sha' |
Contributor
There was a problem hiding this comment.
What shell are you using? I thought you'd need backticks to execute commands and return their output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change seeks to ensure we mantain gem version parity as per this issue and the subsequent card , we really need to ensure we update the gem version in at least three places.
This is the first pass at automating that change, via adding an automated tag release via the gh cli and creating new prs in the relevant repos so we know what work needs to be done, which will fire whenever anyone runs the release script
As part of the cleanup task I'd like to
This is ready for a first pass. I've manually tested this by running through the command flow starting with line 46 in the script/release file (with some manual interpolations), as part of the work I'm going to create a new release which will test things end to end and let me clean up the dependent repos, but i'm going to tackle #3 first.
Feedback on the idea, the implementation, and the general direction of this work. Its possible that point #1 is too much work for how often we release new gems, and we should focus on 2 and 3.