Adds prettier and eslint by lindseywild · Pull Request #138 · github/accessibility-scanner

lindseywild · 2026-02-19T21:43:18Z

Closes #135.

Adds Prettier & ESLint
Adds new CI check for linting
Updates all current files based on linting / formatting feedback

I've confirmed this still runs on an internal repo.

Copilot

Pull request overview

Adds repository-wide formatting and linting tooling to standardize TypeScript code style across the GitHub Actions codebase and tests, and introduces CI enforcement for lint/format checks.

Changes:

Add Prettier + ESLint (flat config) with npm scripts to lint and format TS sources.
Add a new CI workflow to run npm run lint and npm run format:check.
Apply formatting/lint-driven edits across action sources and tests (plus a small API adjustment to generateIssueBody).

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/site-with-errors.test.ts	Prettier-driven formatting updates in tests.
package.json	Adds lint/format scripts, devDependencies for Prettier/ESLint, and sets root package to ESM.
package-lock.json	Locks newly added lint/format dependencies and their transitive deps.
eslint.config.js	Introduces ESLint flat config using `typescript-eslint` + `eslint-config-prettier`.
.prettierrc.json	Adds Prettier formatting rules (semi, trailing commas, etc.).
.github/workflows/lint.yml	New CI workflow to enforce linting and format checks.
.github/actions/fix/src/retry.ts	Formatting (comma) update for parameter list.
.github/actions/fix/src/index.ts	Formatting updates (trailing commas in multi-line calls).
.github/actions/fix/src/getLinkedPR.ts	Formatting updates (trailing commas).
.github/actions/fix/src/assignIssue.ts	Formatting updates (trailing commas).
.github/actions/fix/src/Issue.ts	Formatting updates for readability and semicolons.
.github/actions/find/src/index.ts	Formatting + minor `let`→`const` adjustment for `findings`.
.github/actions/find/src/findForUrl.ts	Formatting updates; renames caught error to `_e` to satisfy linting.
.github/actions/file/tests/generateIssueBody.test.ts	Formatting updates (but still calls `generateIssueBody` with an outdated signature).
.github/actions/file/src/updateFilingsWithNewFindings.ts	Formatting (comma) update for parameter list.
.github/actions/file/src/reopenIssue.ts	Formatting updates; multi-line request call formatting.
.github/actions/file/src/openIssue.ts	Formatting + updates to call `generateIssueBody` with new signature.
.github/actions/file/src/index.ts	Formatting updates; adds an ESLint disable + `any` cast when attaching `issue` to a filing.
.github/actions/file/src/generateIssueBody.ts	Removes unused `repoWithOwner` parameter; formatting cleanup.
.github/actions/file/src/closeIssue.ts	Formatting updates; multi-line request call formatting.
.github/actions/file/src/Issue.ts	Formatting update (trailing comma).
.github/actions/auth/src/index.ts	Removes unused imports and reformats `reduce` logic for `localStorage` output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T22:12:38Z

.github/actions/file/tests/generateIssueBody.test.ts

@@ -17,7 +19,9 @@ describe("generateIssueBody", () => {

    expect(body).toContain("## What");
    expect(body).toContain("## Acceptance Criteria");
-    expect(body).toContain("The specific axe violation reported in this issue is no longer reproducible.");
+    expect(body).toContain(


generateIssueBody now only accepts a single finding argument, but this test still passes a second repoWithOwner parameter. This makes the test inconsistent with the function’s public API and would fail type-checking if tsc is added later. Update the test calls to pass only the finding object (or reintroduce the second parameter if it’s still intended to be part of the API).

Copilot · 2026-02-19T22:12:38Z

.github/actions/file/src/index.ts

+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
        (filing as any).issue = { state: "open" } as Issue;


This bypasses typing with (filing as any) and disables @typescript-eslint/no-explicit-any, which weakens the guarantees around the Filing union (notably NewFiling currently forbids issue). Prefer updating the Filing/NewFiling types (or introducing a post-file “filed” type) so you can assign issue without any and without disabling the rule.

Suggested change

// eslint-disable-next-line @typescript-eslint/no-explicit-any

(filing as any).issue = { state: "open" } as Issue;

// Attach an initial Issue placeholder; it will be populated once we have the API response.

(filing as typeof filing & { issue: Issue }).issue = { state: "open" } as Issue;

Copilot · 2026-02-19T22:12:38Z

package.json

    "@types/node": "^25.2.0",
+    "eslint": "^10.0.0",
+    "eslint-config-prettier": "^10.1.8",
+    "prettier": "^3.8.1",


typescript-eslint relies on typescript as a peer dependency, but typescript isn’t declared in this root package.json (it’s only present via the lockfile). To avoid installs depending on npm’s peer-dep behavior and to make the toolchain explicit/reproducible, add typescript to devDependencies here (and keep its version aligned with the workspace/actions as needed).

Suggested change

"prettier": "^3.8.1",

"prettier": "^3.8.1",

"typescript": "^5.7.3",

smockle · 2026-02-20T01:40:22Z

I’m going to remove this from the FR queue. If FR support is required, please feel free to re-add it!

JoyceZhu · 2026-02-20T05:17:37Z

.prettierrc.json

@@ -0,0 +1,6 @@
+{


Should we point to our org-level Prettier config instead of configuring options here?

Updated, ty for pointing this out!

abdulahmad307 · 2026-02-20T14:49:12Z

eslint.config.js

+import tseslint from "typescript-eslint";
+import prettierConfig from "eslint-config-prettier";
+
+export default tseslint.config(...tseslint.configs.recommended, prettierConfig, {


do we want to enforce a max limit on lines of code in functions? or is that not something others are comfortable with.
If we do want to enforce it, I think ~25 lines is reasonable. I've worked in teams that enforce 12 but that's a bit extreme.

Good question! I switched to using the default GH Prettier config, so I'd say let's defer to whatever they do there :)

abdulahmad307

one question. non blocking.

lindseywild · 2026-02-20T15:53:11Z

@JoyceZhu @abdulahmad307 Updated to use the main GH Prettier config; also confirmed all internal scans are still passing 👍🏻

lindseywild added 12 commits February 19, 2026 21:25

Adds eslint & prettier

4bbb8bc

Files that are linted and prettiered

74498c8

Sets back to any

dab687e

Adds lint to CI

0a35dcc

Testing reverting file

7320f1c

Testing reverting file

853ba27

Updates find files

1300fe4

Updates a few files

e796fc6

Removes auth unused files

d630300

Updates generate issue body

310d936

More files

41e9a3b

More

f052c0b

lindseywild marked this pull request as ready for review February 19, 2026 22:07

lindseywild requested a review from a team as a code owner February 19, 2026 22:07

lindseywild requested review from accessibility-bot and Copilot February 19, 2026 22:07

Copilot started reviewing on behalf of lindseywild February 19, 2026 22:07 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

JoyceZhu reviewed Feb 20, 2026

View reviewed changes

abdulahmad307 reviewed Feb 20, 2026

View reviewed changes

abdulahmad307 previously approved these changes Feb 20, 2026

View reviewed changes

Uses GitHub prettier config

889e90b

lindseywild dismissed abdulahmad307’s stale review via 889e90b February 20, 2026 15:44

lindseywild requested review from JoyceZhu and abdulahmad307 February 20, 2026 15:52

abdulahmad307 approved these changes Feb 20, 2026

View reviewed changes

lindseywild merged commit 95a0df4 into main Feb 20, 2026
6 checks passed

lindseywild deleted the adds-prettier-and-eslint branch February 20, 2026 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Adds prettier and eslint#138

Adds prettier and eslint#138
lindseywild merged 13 commits intomainfrom
adds-prettier-and-eslint

lindseywild commented Feb 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

smockle commented Feb 20, 2026

Uh oh!

JoyceZhu Feb 20, 2026 •

edited

Loading

Uh oh!

lindseywild Feb 20, 2026

Uh oh!

abdulahmad307 Feb 20, 2026 •

edited

Loading

Uh oh!

lindseywild Feb 20, 2026

Uh oh!

abdulahmad307 left a comment

Uh oh!

lindseywild commented Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		// eslint-disable-next-line @typescript-eslint/no-explicit-any
		(filing as any).issue = { state: "open" } as Issue;

	"prettier": "^3.8.1",
	"prettier": "^3.8.1",
	"typescript": "^5.7.3",

Comments

Conversation

lindseywild commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

smockle commented Feb 20, 2026

Uh oh!

JoyceZhu Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lindseywild Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

abdulahmad307 Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lindseywild Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

abdulahmad307 left a comment

Choose a reason for hiding this comment

Uh oh!

lindseywild commented Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lindseywild commented Feb 19, 2026 •

edited

Loading

JoyceZhu Feb 20, 2026 •

edited

Loading

abdulahmad307 Feb 20, 2026 •

edited

Loading