Conversation
…gacy, Logging.Legacy
…gya/microdot into us/95878.infra.orleans.2_20.5
…throw meaningfull exception if failes)
| { | ||
| _consulListener.Close(); | ||
| ((IDisposable)_consulListener)?.Dispose(); | ||
| //_consulListener.Close(); |
There was a problem hiding this comment.
Should understand the issue.
dispose should not throw an exception or cause other side effects
| <Discovery> | ||
| <Services> | ||
| <CalculatorService Source="Local" /> | ||
| <CalculatorService Source="Config" Hosts="127.0.0.1" DefaultPort="12323"/> |
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> | ||
| <PackageVersion>7.0.3-beta</PackageVersion> |
There was a problem hiding this comment.
The package version should be 6.
The build server Identify branch is not master and therefor create a beta version.
Also, we want one nuspec file that controls the version. ( microdot come as a full package)
| throw new ArgumentNullException(nameof(name)); | ||
|
|
||
| OsUser = WindowsIdentity.GetCurrent().Name; | ||
| OsUser = "N/A"; |
There was a problem hiding this comment.
can you find a way in Linux to get the Current user?
| // ReSharper disable once PossibleNullReferenceException | ||
| IsRunningAsWindowsService = Environment.OSVersion.Platform == PlatformID.Win32NT && | ||
| WindowsIdentity.GetCurrent().Name == @"NT AUTHORITY\SYSTEM"; | ||
| IsRunningAsWindowsService = false; |
There was a problem hiding this comment.
@daniel-lamberger can we remove WindowsService support?
| } | ||
| } | ||
| finally | ||
| { |
There was a problem hiding this comment.
we need more investigation to understand doker in Linux
| { | ||
| Placehodler = "%" + match.Groups[1].Value + "%", | ||
| Value = _environmentVariableProvider.GetEnvironmentVariable(match.Groups[1].Value) | ||
| Value = _environmentVariableProvider.GetEnvironmentVariable(match.Groups[1].Value.ToUpper()) |
There was a problem hiding this comment.
- Can you please move the ToUpper to the where.
- add readme that describes our environment variable format ( Upper case key, lower case value )
| private void CreateRootWatcher() | ||
| { | ||
|
|
||
| var usePolling = Environment.GetEnvironmentVariable("GIGYA_CONFIG_USE_POLLING"); |
There was a problem hiding this comment.
@daniel-lamberger what do you think about polling instead of Watcher.
(due to docker on windows have no support in file system Watcher)
| /// https://github.com/dotnet/orleans/issues/5876 | ||
| /// </summary> | ||
| [Test] | ||
| [Test, Ignore("Waiting for issue to be fixed by Orleans")] |
There was a problem hiding this comment.
let's try to find other solution for that
| //Disable TracingContext.SetRequestID("1"); | ||
|
|
||
| CallContext.FreeNamedDataSlot("#ORL_RC"); | ||
| TracingContext.ClearContext();// CallContext.FreeNamedDataSlot("#ORL_RC"); |
There was a problem hiding this comment.
remove zombi code :P
…n outgoing requests
No description provided.