Skip to content

ref: add a type assertion for marker #88915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

ref: add a type assertion for marker #88915

merged 1 commit into from
Apr 9, 2025

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Apr 7, 2025

it's a complex type that potentially can't be stringified, but I guess in our cases it's just always a string at runtime

@TkDodo
ref: add a type assertion for marker
34aaa23 
it's a complex type that potentially can't be stringified, but I guess in our cases it's just always a string at runtime
@TkDodo TkDodo marked this pull request as ready for review April 7, 2025 15:09
@TkDodo TkDodo requested review from a team as code owners April 7, 2025 15:09
@TkDodo TkDodo requested a review from JonasBa April 7, 2025 15:10
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 7, 2025
ryan953
ryan953 approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be better/different to call String(marker) to coerce the value?

@TkDodo
Copy link
Contributor Author

TkDodo commented Apr 7, 2025

Could it be better/different to call String(marker) to coerce the value?

no. for context, I’m working on no-base-to-string, which specifically disallows calling .toString() or String() around things that can be an object, because it would yield [object Object] at runtime.

@TkDodo TkDodo merged commit ac196ee into master Apr 9, 2025
42 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/stringify-marker-in-charts branch April 9, 2025 09:05
Christinarlong pushed a commit that referenced this pull request Apr 10, 2025
@TkDodo @Christinarlong
ref: add a type assertion for marker (#88915)
dc9b926 
it's a complex type that potentially can't be stringified, but I guess
in our cases it's just always a string at runtime
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
@TkDodo @andrewshie-sentry
ref: add a type assertion for marker (#88915)
6455094 
it's a complex type that potentially can't be stringified, but I guess
in our cases it's just always a string at runtime
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryan953 ryan953 ryan953 approved these changes

@JonasBa JonasBa Awaiting requested review from JonasBa

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TkDodo @ryan953