chore(eslint): Enable and fix (manual & auto) prefer-array-some #88870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan953
commented
Apr 5, 2025
|
|
||
| if (['sumdelta'].find(denied => tagSort?.includes(denied))) { |
There was a problem hiding this comment.
wat? must've been adjusted a few times over it's life...
ryan953
commented
Apr 5, 2025
Comment on lines
-368
to
-370
| const aggregate = Object.keys(scoresByInterface) | ||
| // @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message | ||
| .map(interfaceName => [interfaceName, scoresByInterface[interfaceName]]) |
scttcper
approved these changes
Apr 7, 2025
4a89fb2 to
0a364b9
Compare
6ee4f9e to
6d32019
Compare
b30c644 to
5e598cd
Compare
No need for `.map(Boolean).some(Boolean)` it's already been through `.slice(1)` too...
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
<!-- Describe your PR here. --> --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.