feat(aci): add CollapsibleSection component
#88868
Merged
+116
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemoo-re
reviewed
Apr 7, 2025
There was a problem hiding this comment.
Looking good but the markup needs some work! Styling details can be a bit tricky, so I'd recommend diving into this CSS Tricks article.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88868 +/- ##
===========================================
+ Coverage 42.13% 87.73% +45.60%
===========================================
Files 10058 10065 +7
Lines 568873 569006 +133
Branches 22435 22304 -131
===========================================
+ Hits 239722 499245 +259523
+ Misses 328740 69362 -259378
+ Partials 411 399 -12 |
natemoo-re
approved these changes
Apr 7, 2025
| border: 1px solid ${p => p.theme.border}; | ||
| border-radius: ${p => p.theme.borderRadius}; | ||
| padding: ${space(2)} ${space(2)}; | ||
|
|
There was a problem hiding this comment.
Cursors remain a hotly debated topic in web circles, but our buttons use pointers, so this component probably should too.
Suggested change
| cursor: pointer; |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
adding a new `CollapsibleSection` component to be used on monitor/automation creation pages see stories [here](https://sentry-exxec9mu5.sentry.dev/stories/?name=app/components/workflowEngine/ui/collapsibleSection.stories.tsx&query=colla) <img width="783" alt="Screenshot 2025-04-04 at 4 32 57 PM" src="https://github.com/user-attachments/assets/c42d1d36-239f-4ac8-a03e-11395714a681" /> --------- Co-authored-by: Nate Moore <[email protected]>
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
adding a new `CollapsibleSection` component to be used on monitor/automation creation pages see stories [here](https://sentry-exxec9mu5.sentry.dev/stories/?name=app/components/workflowEngine/ui/collapsibleSection.stories.tsx&query=colla) <img width="783" alt="Screenshot 2025-04-04 at 4 32 57 PM" src="https://github.com/user-attachments/assets/c42d1d36-239f-4ac8-a03e-11395714a681" /> --------- Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a new
CollapsibleSectioncomponent to be used on monitor/automation creation pagessee stories here