fix(uptime): Make sure we unassign seats when an uptime monitor fails auto onboarding #88866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… auto onboarding We assign a seat to uptime monitors when we auto create them. But if they fail the onboarding process, they call an older function that isn't aware of disabling seats. This pr removes that function and calls our standard deletion function. The logic that the old function implemented only mattered when we used to share `UptimeSubscription` rows between multiple `ProjectUptimeSubscription` rows. But now that things are 1-1, we can just call delete directly.
wedamija
commented
Apr 4, 2025
| ProjectUptimeSubscriptionMode.AUTO_DETECTED_ACTIVE, | ||
| ], | ||
| ) | ||
| delete_project_uptime_subscription(monitored_subscription) |
There was a problem hiding this comment.
Right now, this code is never called because we only ever detect a single url for a project. But this is the correct behaviour if we ever change that.
vbro
approved these changes
Apr 5, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
… auto onboarding (#88866) We assign a seat to uptime monitors when we auto create them. But if they fail the onboarding process, they call an older function that isn't aware of disabling seats. This pr removes that function and calls our standard deletion function. The logic that the old function implemented only mattered when we used to share `UptimeSubscription` rows between multiple `ProjectUptimeSubscription` rows. But now that things are 1-1, we can just call delete directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assign a seat to uptime monitors when we auto create them. But if they fail the onboarding process, they call an older function that isn't aware of disabling seats.
This pr removes that function and calls our standard deletion function. The logic that the old function implemented only mattered when we used to share
UptimeSubscriptionrows between multipleProjectUptimeSubscriptionrows. But now that things are 1-1, we can just call delete directly.