feat(uptime): Add basic detector config schema for uptime #88860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
commented
Apr 4, 2025
| @@ -131,5 +131,4 @@ def enforce_config_schema(sender, instance: Detector, **kwargs): | |||
| raise ValidationError("Detector config must be a dictionary") | |||
|
|
|||
| config_schema = group_type.detector_config_schema | |||
| if instance.config: | |||
There was a problem hiding this comment.
We should be validating the config always, since some fields are required and an empty config means we don't have those fields
evanpurkhiser
approved these changes
Apr 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88860 +/- ##
==========================================
- Coverage 87.70% 87.70% -0.01%
==========================================
Files 10105 10106 +1
Lines 571788 571821 +33
Branches 22469 22469
==========================================
+ Hits 501474 501499 +25
- Misses 69893 69901 +8
Partials 421 421 |
5fe00e5 to
71ac914
Compare
03bccb2 to
706b17c
Compare
saponifi3d
reviewed
Apr 9, 2025
src/sentry/testutils/factories.py
Outdated
| @@ -321,6 +322,10 @@ def make_word(words=None): | |||
| "platform": "python", | |||
| } | |||
|
|
|||
| default_detector_config_data = { | |||
There was a problem hiding this comment.
this stuff just showing up from the other pr cause of base branch?
There was a problem hiding this comment.
Yeah, I hadn't rebased yet, so github was probably confused
This adds a basic config schema for uptime. For now it includes mode and environment.
706b17c to
5eda234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic config schema for uptime. For now it includes mode and environment.