fix(dashboards-eap): Show preflight table results during loading #88850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unnecessary for now
narsaynorath
commented
Apr 7, 2025
| @@ -170,7 +170,7 @@ function SpansWidgetQueriesProgressiveLoadingImpl({ | |||
| // the best effort query has completed. | |||
| children({ | |||
| ...(bestEffortChildrenProps ?? preflightProps), | |||
| isProgressivelyLoading: preflightProps.loading, | |||
There was a problem hiding this comment.
I'm not actually using isProgressivelyLoading at the moment, but loading is being used. I'm removing it from here but I'll revisit it when I come back to fixing up the UI from the higher component.
edwardgou-sentry
approved these changes
Apr 7, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
) When the table was loading, it would show a placeholder over the data so we wouldn't be able to see the preflight results. This removes the placeholder for span table widgets so we can see the underlying data. I also had to update the widget queries component to pass along the loading prop or else it used to get overridden by the cached (i.e. stored in a state variable) results from the best effort request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the table was loading, it would show a placeholder over the data so we wouldn't be able to see the preflight results. This removes the placeholder for span table widgets so we can see the underlying data.
I also had to update the widget queries component to pass along the loading prop or else it used to get overridden by the cached (i.e. stored in a state variable) results from the best effort request.