feat(insights): convert more web vitals to eap #88840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88840 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 10066 10066
Lines 569533 569512 -21
Branches 22359 22357 -2
=======================================
- Hits 499662 499647 -15
+ Misses 69472 69466 -6
Partials 399 399 |
edwardgou-sentry
approved these changes
Apr 7, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
1. add default query for eap (eap does not have transaction.op, but instead uses span.op) 2. Use `useMetrics` in a few more spots that I missed in #88693 3. Update `useMetricsSeries` to conditionally fetch eap data 4. Use `opportunity_score(measurements.score.total` if eap is enabled, otherwise use `total_opportunity_score` 5. Remove several unused fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useMetricsin a few more spots that I missed in ref(insights): update web vitals to useuseMetrics#88693useMetricsSeriesto conditionally fetch eap dataopportunity_score(measurements.score.totalif eap is enabled, otherwise usetotal_opportunity_score