fix(autofix): Poll for PR state #88832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
jennmueng
reviewed
Apr 7, 2025
Comment on lines
+181
to
+182
| const [isPrProcessing, setIsPrProcessing] = useState(false); | ||
| const [isBranchProcessing, setIsBranchProcessing] = useState(false); |
There was a problem hiding this comment.
could we make these conditions completely reliant on the autofix state instead of being react state? We can just rely on the changes step being in processing status right? Will make all this logic much simpler
If on the seer side we update the status before we return the call then the query invalidation inside onSuccess should already receive a processing state next time it makes a request
jennmueng
reviewed
Apr 7, 2025
| @@ -99,7 +99,7 @@ export function useSelectSolution({groupId, runId}: {groupId: string; runId: str | |||
| }; | |||
| } | |||
| ); | |||
| addSuccessMessage("Great, let's move forward with this solution."); | |||
| addSuccessMessage('On it.'); | |||
jennmueng
approved these changes
Apr 7, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
When creating a branch/PR, we now poll for the state instead of waiting for an API response. This should be more reliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a branch/PR, we now poll for the state instead of waiting for an API response. This should be more reliable.