fix(dashboards): Improve "Highlighting" story for TimeSeriesWidgetVisualization
#88828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…sualization` (#88828) There's a problem in that story! Right now clicking "Highlight Random Sample" doesn't work properly because right after dispatching the `"highlight"` event to ECharts, it also updates a local state, which re-renders the chart, and the highlight get clobbered. I was going to fix this issue by wrapping the chart in `memo`, but that's not a proper solution. `memo` is _only_ a performance optimization, we can't rely on it to maintain uncontrolled chart state for us. The correct solution is to use `useEffect`, which is designed for this exact scenario: synchronizing a local React state with something that React doesn't control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem in that story! Right now clicking "Highlight Random Sample" doesn't work properly because right after dispatching the
"highlight"event to ECharts, it also updates a local state, which re-renders the chart, and the highlight get clobbered. I was going to fix this issue by wrapping the chart inmemo, but that's not a proper solution.memois only a performance optimization, we can't rely on it to maintain uncontrolled chart state for us.The correct solution is to use
useEffect, which is designed for this exact scenario: synchronizing a local React state with something that React doesn't control.