feat(taskworker): Make hybridcloud taskworker compatible #88824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
approved these changes
Apr 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this [document](https://www.notion.so/sentry/Rollout-Planning-1bd8b10e4b5d80aeaaa7dba0efca83bc). Notable changes/callouts Most of relocation tasks use retry_backof, retry_backoff_jitter, and soft_time_limit which taskworker does not support LastAction (action taken when retries are exhausted) is set to discard sentry.relocation.fulfill_cross_region_export_request uses reject_on_worker_lost which is already the default behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this document.
Notable changes/callouts
Most of relocation tasks use retry_backof, retry_backoff_jitter, and soft_time_limit which taskworker does not support
LastAction (action taken when retries are exhausted) is set to discard
sentry.relocation.fulfill_cross_region_export_request uses reject_on_worker_lost which is already the default behaviour