Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): all queries table style #88820

Merged
merged 10 commits into from
Apr 7, 2025

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Apr 4, 2025

Updates Saved Queries table to use new styling:
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10125 1 10124 5
View the top 1 failed test(s) by shortest run time
SavedQueriesTable should display starred status
Stack Traces | 0.101s run time
TestingLibraryElementError: Unable to find a label with the text of: Starred Queries

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at getAllByLabelText (.../sentry/sentry/node_modules/@.../dist/queries/label-text.js:111:38)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../explore/savedQueries/savedQueriesTable.spec.tsx:158:40)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Base automatically changed from egou/feat/explore-saved-queries-rename to master April 7, 2025 16:58
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review April 7, 2025 17:19
@edwardgou-sentry edwardgou-sentry requested review from a team as code owners April 7, 2025 17:19
@edwardgou-sentry edwardgou-sentry requested a review from a team April 7, 2025 17:19
@edwardgou-sentry edwardgou-sentry merged commit a101f8e into master Apr 7, 2025
42 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/all-queries-table-style branch April 7, 2025 18:33
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Updates Saved Queries table to use new styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants