fix(taskworker) Remove countdown from relay tasks #88819
Merged
+6
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reviewing our usage of `countdown` I noticed that these tasks are being delayed without a good reason. We already debounce task scheduling with `projectconfig_debounce_cache` and `transaction.on_commit` and the additional 5s delay doesn't really prevent any races. Refs #88091
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88819 +/- ##
========================================
Coverage 87.73% 87.73%
========================================
Files 10066 10067 +1
Lines 569413 569514 +101
Branches 22355 22355
========================================
+ Hits 499551 499649 +98
- Misses 69463 69466 +3
Partials 399 399 |
evanh
approved these changes
Apr 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
When reviewing our usage of `countdown` I noticed that these tasks are being delayed without a good reason. We already debounce task scheduling with `projectconfig_debounce_cache` and `transaction.on_commit` and the additional 5s delay doesn't really prevent any races. Refs #88091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing our usage of
countdownI noticed that these tasks are being delayed without a good reason. We already debounce task scheduling withprojectconfig_debounce_cacheandtransaction.on_commitand the additional 5s delay doesn't really prevent any races.Refs #88091