feat(rpc): add private attributes #88818
Merged
+89
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmak
commented
Apr 4, 2025
- This adds the fields that were in trace_item_details' DISALLOW_LIST to our full list of attributes, and then marks them private
- The goal here is that all possible columns in the RPC are defined in attributes and we define the expected behaviours for all of them
- This adds the fields that were in trace_item_details' DISALLOW_LIST to our full list of attributes, and then marks them private - The goal here is that all possible columns in the RPC are defined in attributes and we define the expected behaviours for all of them
k-fish
approved these changes
Apr 4, 2025
Comment on lines
-27
to
-30
| DISALLOW_LIST = { | ||
| "sentry.organization_id", | ||
| "sentry.item_type", | ||
| } |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
- This adds the fields that were in trace_item_details' DISALLOW_LIST to our full list of attributes, and then marks them private - The goal here is that all possible columns in the RPC are defined in attributes and we define the expected behaviours for all of them
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.