Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): Allow non daily bar graphs when using spans #88816

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Apr 4, 2025

When using eap spans in dashboards, we should permit non daily bar graphs. Here we use the fidelity latter defined for spans.

When using eap spans in dashboards, we should permit non daily bar graphs. Here
we use the fidelity latter defined for spans.
@Zylphrex Zylphrex requested a review from a team as a code owner April 4, 2025 17:08
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 4, 2025
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Zylphrex Zylphrex merged commit c873a59 into master Apr 4, 2025
43 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/allow-non-daily-bar-graphs-when-using-spans-in-dashboards branch April 4, 2025 17:31
@gggritso
Copy link
Member

gggritso commented Apr 4, 2025

🤔 but why? What's different about EAP vs. other datasets in this respect?

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
When using eap spans in dashboards, we should permit non daily bar
graphs. Here we use the fidelity latter defined for spans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants