chore(profiling): Stop reporting unactionable unknown sdk errors #88811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's not much we can do about this error until we can reject profile chunks below the minimum sdk version. So stop reporting it since it's just noise.
phacops
approved these changes
Apr 4, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88811 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 10066 10066
Lines 569367 569394 +27
Branches 22355 22355
=======================================
+ Hits 499489 499519 +30
+ Misses 69479 69476 -3
Partials 399 399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's not much we can do about this error until we can reject profile chunks below the minimum sdk version. So stop reporting it since it's just noise.