fix(insights): http sample panel not setting eap flag #88798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narsaynorath
approved these changes
Apr 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88798 +/- ##
===========================================
+ Coverage 51.66% 87.72% +36.05%
===========================================
Files 9940 10064 +124
Lines 567762 569178 +1416
Branches 22355 22355
===========================================
+ Hits 293335 499303 +205968
+ Misses 274028 69477 -204551
+ Partials 399 398 -1 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
We should set `useRpc = 1` when we want the sample panel to use eap rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set
useRpc = 1when we want the sample panel to use eap rpc